mikepenz/release-changelog-builder-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- fix array placeholders are not correctly replaced

Browse Source
This commit is contained in:
Mike Penz
2023-02-26 12:15:03 +00:00
committed by GitHub
parent cad1ca5504
commit 6757bebf45
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/transform.ts
+5 -5
View File
@@ -269,7 +269,7 @@ export function replaceEmptyTemplate(template: string, options: ReleaseNotesOpti
} }
const placeholderMap = new Map<string, string>() const placeholderMap = new Map<string, string>()
fillAdditionalPlaceholders(options, placeholderMap) fillAdditionalPlaceholders(options, placeholderMap)
return replacePlaceholders(template, new Map<string, string>(), placeholderMap, placeholders, undefined, options.configuration) return replacePlaceholders(template, EMPTY_MAP, placeholderMap, placeholders, undefined, options.configuration)
} }
function fillAdditionalPlaceholders( function fillAdditionalPlaceholders(
@@ -394,9 +394,9 @@ function fillArrayPlaceholders(
values: string[] values: string[]
): void { ): void {
for (let i = 0; i < values.length; i++) { for (let i = 0; i < values.length; i++) {
placeholderMap.set(`\${{${key}[${i}]}}`, values[i]) placeholderMap.set(`${key}[${i}]`, values[i])
} }
placeholderMap.set(`\${{${key}[*]}}`, values.join(', ')) placeholderMap.set(`${key}[*]`, values.join(', '))
} }
function fillReviewPlaceholders( function fillReviewPlaceholders(
@@ -407,10 +407,10 @@ function fillReviewPlaceholders(
// retrieve the keys from the CommentInfo object // retrieve the keys from the CommentInfo object
for (const childKey of Object.keys(EMPTY_COMMENT_INFO)) { for (const childKey of Object.keys(EMPTY_COMMENT_INFO)) {
for (let i = 0; i < values.length; i++) { for (let i = 0; i < values.length; i++) {
placeholderMap.set(`\${{${parentKey}[${i}].${childKey}}}`, values[i][childKey as keyof CommentInfo]?.toLocaleString('en') || '') placeholderMap.set(`${parentKey}[${i}].${childKey}`, values[i][childKey as keyof CommentInfo]?.toLocaleString('en') || '')
} }
placeholderMap.set( placeholderMap.set(
`\${{${parentKey}[*].${childKey}}}`, `${parentKey}[*].${childKey}`,
values.map(value => value[childKey as keyof CommentInfo]?.toLocaleString('en') || '').join(', ') values.map(value => value[childKey as keyof CommentInfo]?.toLocaleString('en') || '').join(', ')
) )
} }