Merge pull request #1391 from mikepenz/fix/external_contributors

Fix Contributor template

configs/configuration_repo.json

@@ -21,7 +21,7 @@
             "labels": ["dependencies"]
         }
     ],
-    "template": "${{CHANGELOG}}\n\nContributors:\n${{CONTRIBUTORS}}",
+    "template": "#{{CHANGELOG}}\n\nContributors:\n- #{{CONTRIBUTORS}}",
     "max_pull_requests": 1000,
     "max_back_track_time_days": 1000
 }

dist/index.js

@@ -2707,7 +2707,7 @@ function buildChangelog(diffInfo, origPrs, options) {
     const contributorsSet = new Set(prs.map(pr => `@${pr.author}`));
     const contributorsArray = Array.from(contributorsSet);
     const contributorsString = contributorsArray.join(', ');
-    const externalContributorString = contributorsArray.filter(value => value !== options.owner).join(', ');
+    const externalContributorString = contributorsArray.filter(value => value !== `@${options.owner}`).join(', ');
     core.setOutput('contributors', JSON.stringify(contributorsSet));
     const releaseNotesTemplateContext = buildReleaseNotesTemplateContext(changelogStrings, contributorsString, externalContributorString, prStrings, diffInfo, options);
     let renderedReleaseNotesTemplate = renderTemplateAndFillPlaceholderContext(config.template, releaseNotesTemplateContext, groupedPlaceholders, customPlaceholdersTemplateContext, config);

src/transform.ts

@@ -178,7 +178,7 @@ export function buildChangelog(diffInfo: DiffInfo, origPrs: PullRequestInfo[], o
   const contributorsSet: Set<string> = new Set(prs.map(pr => `@${pr.author}`))
   const contributorsArray = Array.from(contributorsSet)
   const contributorsString = contributorsArray.join(', ')
-  const externalContributorString = contributorsArray.filter(value => value !== options.owner).join(', ')
+  const externalContributorString = contributorsArray.filter(value => value !== `@${options.owner}`).join(', ')
   core.setOutput('contributors', JSON.stringify(contributorsSet))
 
   const releaseNotesTemplateContext = buildReleaseNotesTemplateContext(