From 80485ce20e88f0edeffc1768b10f658bcf10aff4 Mon Sep 17 00:00:00 2001 From: Mike Penz Date: Fri, 28 Jul 2023 10:08:17 +0000 Subject: [PATCH] - update tests for new configuration option --- __tests__/releaseNotesBuilder.test.ts | 14 ++++++++++++++ __tests__/releaseNotesBuilderPull.test.ts | 14 ++++++++++++-- __tests__/tags.test.ts | 2 +- __tests__/transform.test.ts | 12 +++++------- 4 files changed, 32 insertions(+), 10 deletions(-) diff --git a/__tests__/releaseNotesBuilder.test.ts b/__tests__/releaseNotesBuilder.test.ts index 9fbdb0a..0ea31f6 100644 --- a/__tests__/releaseNotesBuilder.test.ts +++ b/__tests__/releaseNotesBuilder.test.ts @@ -16,6 +16,7 @@ it('Should match generated changelog (unspecified fromTag)', async () => { false, false, false, + true, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -47,6 +48,7 @@ it('Should match generated changelog (unspecified tags)', async () => { false, false, false, + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -73,6 +75,7 @@ it('Should use empty placeholder', async () => { false, false, false, + true, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -99,6 +102,7 @@ it('Should fill empty placeholders', async () => { false, false, false, + true, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -127,6 +131,7 @@ it('Should fill `template` placeholders', async () => { false, false, false, + true, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -156,6 +161,7 @@ it('Should fill `template` placeholders, ignore', async () => { false, false, false, + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -184,6 +190,7 @@ it('Uncategorized category', async () => { false, false, false, + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -212,6 +219,7 @@ it('Verify commit based changelog', async () => { false, false, false, + true, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -240,6 +248,7 @@ it('Verify commit based changelog, with emoji categorisation', async () => { false, false, false, + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -268,6 +277,7 @@ it('Verify default inclusion of open PRs', async () => { true, // includeOpen false, // failOnError false, // ignorePrePrelease + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -296,6 +306,7 @@ it('Verify custom categorisation of open PRs', async () => { true, // includeOpen false, // failOnError false, // ignorePrePrelease + false, // enable to fetch via commits false, // enable to fetch reviewers false, // enable to fetch tag release information false, // enable to fetch reviews @@ -324,6 +335,7 @@ it('Verify reviewers who approved are fetched and also release information', asy true, // includeOpen false, // failOnError false, // ignorePrePrelease + false, // enable to fetch via commits true, // enable to fetch reviewers true, // enable to fetch tag release information false, // enable to fetch reviews @@ -353,6 +365,7 @@ it('Fetch release information', async () => { true, // includeOpen false, // failOnError false, // ignorePrePrelease + false, // enable to fetch via commits false, // enable to fetch reviewers true, // enable to fetch tag release information false, // enable to fetch reviews @@ -380,6 +393,7 @@ it('Fetch release information for non existing tag / release', async () => { true, // includeOpen false, // failOnError false, // ignorePrePrelease + false, // enable to fetch via commits false, // enable to fetch reviewers true, // enable to fetch tag release information false, // enable to fetch reviews diff --git a/__tests__/releaseNotesBuilderPull.test.ts b/__tests__/releaseNotesBuilderPull.test.ts index 709a707..af9de42 100644 --- a/__tests__/releaseNotesBuilderPull.test.ts +++ b/__tests__/releaseNotesBuilderPull.test.ts @@ -1,7 +1,7 @@ import {mergeConfiguration, resolveConfiguration} from '../src/utils' import {Octokit} from '@octokit/rest' import {buildChangelog} from '../src/transform' -import { pullData } from 'github-pr-collector' +import {pullData} from 'github-pr-collector' jest.setTimeout(180000) @@ -20,6 +20,7 @@ it('Should have empty changelog (tags)', async () => { toTag: {name: 'v0.0.2'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -41,6 +42,7 @@ it('Should match generated changelog (tags)', async () => { toTag: {name: 'v0.0.3'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -61,7 +63,7 @@ it('Should match generated changelog (tags)', async () => { it('Should match generated changelog (refs)', async () => { const configuration = mergeConfiguration(undefined, resolveConfiguration('', 'configs_test/configuration_all_placeholders.json')) - + const options = { owner: 'mikepenz', repo: 'release-changelog-builder-action', @@ -69,6 +71,7 @@ it('Should match generated changelog (refs)', async () => { toTag: {name: 'fa3788c8c4b3373ef8424ce3eb008a5cd07cc5aa'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -104,6 +107,7 @@ it('Should match generated changelog and replace all occurrences (refs)', async toTag: {name: 'fa3788c8c4b3373ef8424ce3eb008a5cd07cc5aa'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -141,6 +145,7 @@ it('Should match ordered ASC', async () => { toTag: {name: 'v0.5.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: false, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -164,6 +169,7 @@ it('Should match ordered DESC', async () => { toTag: {name: 'v0.5.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: false, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -186,6 +192,7 @@ it('Should match ordered by title ASC', async () => { toTag: {name: 'v0.5.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: false, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -209,6 +216,7 @@ it('Should match ordered by title DESC', async () => { toTag: {name: 'v0.5.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: false, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -233,6 +241,7 @@ it('Should ignore PRs not merged into develop branch', async () => { toTag: {name: 'v1.4.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, @@ -254,6 +263,7 @@ it('Should ignore PRs not merged into main branch', async () => { toTag: {name: 'v1.4.0'}, includeOpen: false, failOnError: false, + fetchViaCommits: true, fetchReviewers: false, fetchReleaseInformation: false, fetchReviews: false, diff --git a/__tests__/tags.test.ts b/__tests__/tags.test.ts index 8b2016b..7f28ec8 100644 --- a/__tests__/tags.test.ts +++ b/__tests__/tags.test.ts @@ -1,4 +1,4 @@ -import { TagInfo, filterTags, prepareAndSortTags } from "github-pr-collector/lib/tags" +import {TagInfo, filterTags, prepareAndSortTags} from 'github-pr-collector/lib/tags' jest.setTimeout(180000) diff --git a/__tests__/transform.test.ts b/__tests__/transform.test.ts index 751813a..95522ae 100644 --- a/__tests__/transform.test.ts +++ b/__tests__/transform.test.ts @@ -1,8 +1,8 @@ import {buildChangelog} from '../src/transform' import moment from 'moment' import {Configuration, DefaultConfiguration} from '../src/configuration' -import { PullRequestInfo } from 'github-pr-collector/lib/pullRequests' -import { DefaultDiffInfo } from 'github-pr-collector/lib/commits' +import {PullRequestInfo} from 'github-pr-collector/lib/pullRequests' +import {DefaultDiffInfo} from 'github-pr-collector/lib/commits' jest.setTimeout(180000) @@ -409,16 +409,14 @@ it('Reference PRs', async () => { labels: [] } ] - customConfig.pr_template = "${{NUMBER}} -- ${{REFERENCED[*].number}}" + customConfig.pr_template = '${{NUMBER}} -- ${{REFERENCED[*].number}}' customConfig.reference = { - pattern: '.*\ \#(.).*', // matches the 1 from "abcdefg #1 adfasdf" + pattern: '.* #(.).*', // matches the 1 from "abcdefg #1 adfasdf" on_property: 'body', method: 'replace', target: '$1' } - expect(buildChangelogTest(customConfig, pullRequestsWithLabels)).toStrictEqual( - `1 -- 2\n4 -- \n3 -- \n\n` - ) + expect(buildChangelogTest(customConfig, pullRequestsWithLabels)).toStrictEqual(`1 -- 2\n4 -- \n3 -- \n\n`) }) it('Use empty_content for empty category', async () => {