mikepenz/release-changelog-builder-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1225 from mikepenz/fix/max_pr_bail_condition

Browse Source 
Fix fetching PRs after we reached the max amount
This commit is contained in:
Mike Penz
2023-08-25 10:00:17 +02:00
committed by GitHub
parent bfac64bcd3 ae2c6ccbb5
commit fa2cca75cf
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dist/index.js
Generated Vendored
+3 -2
View File
@@ -842,7 +842,8 @@ class PullRequests {
mergedPRs.push(mapPullRequest(pr, 'merged'));
}
if (mergedPRs.length >= maxPullRequests) {
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests}`);
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests} (1)`);
break; // bail out early to not keep iterating forever
}
else if (prs.length > 0) {
if (fetchedEnough(prs, fromDate)) {
@@ -889,7 +890,7 @@ class PullRequests {
const firstPR = prs[0];
if (firstPR === undefined || openPrs.length >= maxPullRequests) {
if (openPrs.length >= maxPullRequests) {
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests}`);
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests} (2)`);
}
break; // bail out early to not keep iterating forever
}
dist/index.js.map
Generated Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
pr-collector/src/pullRequests.ts
+3 -2
View File
@@ -138,7 +138,8 @@ export class PullRequests {
}
if (mergedPRs.length >= maxPullRequests) {
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests}`)
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests} (1)`)
break // bail out early to not keep iterating forever
} else if (prs.length > 0) {
if (fetchedEnough(prs, fromDate)) {
return sortPrs(mergedPRs) // bail out early to not keep iterating on PRs super old
@@ -173,7 +174,7 @@ export class PullRequests {
const firstPR = prs[0]
if (firstPR === undefined || openPrs.length >= maxPullRequests) {
if (openPrs.length >= maxPullRequests) {
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests}`)
core.warning(`⚠️ Reached 'maxPullRequests' count ${maxPullRequests} (2)`)
}
break // bail out early to not keep iterating forever
}